merge.py: Use git ls-files to get list of downstream PO files#1883
Merged
JulienPalard merged 1 commit intopython:3.10from May 22, 2022
jeanas:merge-files
Merged
merge.py: Use git ls-files to get list of downstream PO files#1883JulienPalard merged 1 commit intopython:3.10from jeanas:merge-files
JulienPalard merged 1 commit intopython:3.10from
jeanas:merge-files
Conversation
The previous method could lead to problems if a dependency installed within venv/ shipped with its own PO files.
Closed
Collaborator
Author
|
Cf. #1880 (comment). |
Member
|
Wow TIL git does its own glob expansion by default. Wow that's funny then in bash, as git and bash don't interpret
But there's no bash involved in your PR so it's 100% right, git will expand properly every time, nicely done! |
JulienPalard
approved these changes
May 22, 2022
Collaborator
|
hat down 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method could lead to problems if a dependency installed
within venv/ shipped with its own PO files.